search

NYCPlanning / labs-community-profiles

A site for exploring indicators, data, and information for NYC community districts
https://communityprofiles.planning.nyc.gov/
Other
52 stars 9 forks source link

matcher as static method #690

Closed TangoYankee closed 1 year ago

TangoYankee commented 1 year ago

Description

When originally linting navigation-dropdown.js, I received a class-methods-use-this error. I interpreted the linting error as pointing out that get(value, 'constructor.modelName') needed a this lookup. After making this change, the get was no longer referencing the function imported from ember/object, causing an error.

This PR correctly interrupts the linting error, which points out that methods without this references can be static. It also reverts the change of using this for get.

Tickets

Closes AB#13484

netlify[bot] commented 1 year ago

Deploy Preview for labs-communityprofiles ready!

Name Link
Latest commit e43091d2d2dab18414666df0b29daa7961870ac1
Latest deploy log https://app.netlify.com/sites/labs-communityprofiles/deploys/64a6e3aad6481a0008c72e34
Deploy Preview https://deploy-preview-690--labs-communityprofiles.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.