search

NYCPlanning / labs-cp-platform

http://capitalplanning.nyc.gov
2 stars 2 forks source link

10042 – Allow commitment level data downloads #75

Closed bmarchena closed 2 years ago

bmarchena commented 2 years ago

A carto helper function was adding an extra "SELECT * FROM " to the beginning of the sql query, leading to an error and preventing users from downloading Commitment Level data.

netlify[bot] commented 2 years ago

Deploy Preview for cp-platform ready!

Name Link
Latest commit 47bd985340e45f2739d6dd0ff931f524b97c7c4b
Latest deploy log https://app.netlify.com/sites/cp-platform/deploys/62f66a43e835420008f3dff5
Deploy Preview https://deploy-preview-75--cp-platform.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

horatiorosa commented 2 years ago

It would have been helpful to see a screenshot of the before and after request. I am wondering if the Commitment Level data download EVER worked and why no one noticed it before.

bmarchena commented 2 years ago

Do you know where sql originally comes from? Is it here?

https://github.com/NYCPlanning/labs-cp-platform/blob/072d4ecf6f788296619de4892c16bed0d1c119a7/app/actions/capitalProjects.js#L22

I have to admit I'm still not sure – it's being passed as a prop to the Download component here at some point but I wasn't able to find an instance of us passing it that prop anywhere in the app