search

NYCPlanning / labs-cp-platform

http://capitalplanning.nyc.gov
2 stars 2 forks source link

10526 – Updates SQL queries to match current Carto columns #81

Closed bmarchena closed 2 years ago

bmarchena commented 2 years ago

Resolves AB#10526.

This PR updates the SQL queries when selecting a geo filter in the dropdown. The queries were referencing column names which have since been changed on Carto.

I decided to implement these changes as if statements directly in the SqlBuilder, instead of changing these labels across the entire application. My thinking is that it will make it just a bit easier to tweak or remove in the future if we find Carto columns changing again.

Community Districts Screen Shot 2022-09-20 at 10 57 52 AM

NTAs Screen Shot 2022-09-20 at 10 58 03 AM

netlify[bot] commented 2 years ago

Deploy Preview for cp-platform ready!

Name Link
Latest commit 1f2253cab6178dd629b0164068d0ec6f8a1f1af2
Latest deploy log https://app.netlify.com/sites/cp-platform/deploys/6329d5dc1ae08600087f1dad
Deploy Preview https://deploy-preview-81--cp-platform.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

horatiorosa commented 2 years ago

~Let's hold on merging this one. ~ I think this was addressed in this PR: PR#76 Never mind, it seems that the updating the column names to match the new ones in Carto did not fix bugs capitalprojects but only in facilities