NYCPlanning / labs-factfinder

New York City Census Reporting Tool
Other
40 stars 12 forks source link

Issue/16067: PFF Updates: ACS—General: comparison area MOE should stop at zero like selected area #1183

Open horatiorosa opened 5 months ago

horatiorosa commented 5 months ago

Description

Charts: comparison area MOE should stop at zero like selected area

Example here

Image

Note

Make a branch from staging and merge all PR back into staging

TylerMatteo commented 4 months ago

@horatiorosa to confirm that this is an existing problem or now.

horatiorosa commented 4 months ago

Going to add this to the backlog as an existing issue and unrelated to the data updates. The comparisonMoebar is extending "behind" the 0% tickmark and ending at the (y) axis-bottom. It seems the maths determining the x may be the root cause / somewhat problematic.

Repro steps:

axis-bottom highlighted

Image

100K-149K comparisonMoe highlighted

Image

100K-149K logged raw data used in the maths

Image

element dimensions used in the maths

Image

function in acs-bar js which calcs the comparisonMoebar

Image

excel doing the actual maths

Image