search

NYCPlanning / labs-factfinder

New York City Census Reporting Tool
Other
40 stars 12 forks source link

Hide values for row headers in Detailed Race and Ethnicity Section #1196

Closed bmarchena closed 6 months ago

bmarchena commented 6 months ago

Adds logic to hide values in current tables

netlify[bot] commented 6 months ago

Deploy Preview for labs-factfinder ready!

Name Link
Latest commit 64ba911d8cdc866c7f886feb8dd624215f615daf
Latest deploy log https://app.netlify.com/sites/labs-factfinder/deploys/664751ee90bd0a00081235f4
Deploy Preview https://deploy-preview-1196--labs-factfinder.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bmarchena commented 6 months ago

@horatiorosa I looked into this pretty thoroughly and ultimately rolled back my changes as a sanity check. It looks like this test was failing before the changes introduced in this PR. Since it's out of scope for our issue, I think we should create another ticket for someone to rewrite this test to work, or remove the test.

horatiorosa commented 6 months ago

@bmarchena Yep, gocha. I can confirm the test is flakey. I skipped the test and will fix the merge conflict via reverting a commit I made to staging afterwards I'll merge in your PR.