Wmg/34 responsive header

NYCPlanning / labs-ideas

Listing of NYC Planning Labs' project pipeline

MIT License

0 stars 0 forks source link

Wmg/34 responsive header #68

Closed allthesignals closed 6 years ago

allthesignals commented 7 years ago

This is functionally responsive, collapsable navigation menu, addressing and closing #34, but I think there are 2 style glitches that @andycochran would know more about:

[ ] Menu prematurely shifts to vertical before collapsing into expandable menu
[ ] Expandable menu state doesn't seem styled correctly? Not sure.

@andycochran let me know if you'd like to tackle these issues or if you could advise how I should approach them. Thanks!!

andycochran commented 7 years ago

My recent change to the site header created a conflict in this PR. I'll take a look at reconciling it.

andycochran commented 7 years ago

I'm not sure this is going to work.

It's styled like this:

But it should look like this:

We don't need to use react-foundation. We just need click on .responsive-nav-toggler to toggle the .show-for-large class on #responsive-menu.