Firefox's padding-bottom bug

NYCPlanning / labs-regional-viz

An interactive mapping experience that highlights regional planning data and trends.

Other

6 stars 1 forks source link

Firefox's padding-bottom bug #182

Closed andycochran closed 6 years ago

andycochran commented 6 years ago

This PR fixes Firefox's bug — ignoring padding-bottom on elements with overflow — on the .narrative-container by moving its bottom padding to an ::after with height.

(Also simplifies the body, html styles.)

daragoldberg commented 6 years ago

@andycochran this is still in progress, right? Latest deploy shows text getting cutoff in the narrative (especially for sources & notes)

andycochran commented 6 years ago

@daragoldberg It just needs two reviewers to approve — ahem, @chriswhong, @allthesignals — then we can merge in this fix.