Upgrade ember - Githubissues

NYCPlanning / labs-regional-viz

An interactive mapping experience that highlights regional planning data and trends.

Other

6 stars 1 forks source link

Upgrade ember #246

Closed allthesignals closed 5 years ago

allthesignals commented 5 years ago

This PR upgrades ember from 2.17 to 3.8. This is a major version change, will need extensive manual testing.

This PR also swaps out the markdown parser with a new one (that's actually managed). The main concern is that it's not clear whether HTML is honored with this new addon. We will manually need to check if the HTML is honored.

allthesignals commented 5 years ago

Oh tests!

allthesignals commented 5 years ago

@hannahkates thanks! I'm looking more for differences between this and production. @andycochran found a few.

allthesignals commented 5 years ago

[ ] On /people/prime-labor-force-gain, clicking the popup throws a SQL error from Carto
[ ] On /housing/renter-owner, clicking "learn more" throws an error "cdn_url is undefined", via Carto's buildTemplate method
[ ] /jobs/institutional-employment-change throws the same error

allthesignals commented 5 years ago

These are issues that show up on develop as well, so they are not new.

allthesignals commented 5 years ago

Created new issue for those issues, let's merge this as they are problems that are already in develop.