search

NYCPlanning / labs-regional-viz

An interactive mapping experience that highlights regional planning data and trends.
Other
6 stars 1 forks source link

Load spinners #77

Open allthesignals opened 6 years ago

allthesignals commented 6 years ago

User Story

I want to see load spinners so I know something is happening after clicking

Description

We need load spinners to communicate that something is happening.

We need to decide whether to use tasks or promises or just use the normal loading substates

andycochran commented 6 years ago

New branch feature/77-map-loading-spinner has a placeholder spinner: 

{{#if loading}}
  {{fa-icon 'spinner' class="fa-spin dark-gray fa-5x map-loading-spinner"}}
{{/if}}

Currently, loading: true is hardcoded. We need to listen for when MapboxGL is done rendering. There's a MapDataEvent we can use as we did in ZoLa: JS, HBS. But I'm not sure exactly how to port this over.

andycochran commented 6 years ago
screen shot 2018-03-29 at 2 38 22 pm
allthesignals commented 6 years ago

I think we regressed on this 🤔

andycochran commented 6 years ago

Looks like it was a conscious choice.

image

I wonder if a refactor along the way broke it. I'll look at the commit history, stand by…