NYCPlanning / labs-streets

The City Map is the official adopted map of the city. It shows the location, dimension and grades of streets, parks, public places, and certain public easements.

http://streets.planning.nyc.gov

Other

10 stars 0 forks source link

add Record Streets legend item #284

Closed andycochran closed 4 years ago

andycochran commented 4 years ago

This PR adds "Record Street" to the legend items.

codecov[bot] commented 4 years ago

Codecov Report

Merging #284 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #284   +/-   ##
========================================
  Coverage    55.01%   55.01%           
========================================
  Files           22       22           
  Lines          289      289           
========================================
  Hits           159      159           
  Misses         130      130

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cea5d6...b6a5bcf. Read the comment docs.

allthesignals commented 4 years ago

Hmm, I'm confused by this static JSON file. Our layers-api is what generates layer-groups, right? Are you sure this is the right thing to be updating? I mean, I can see that it works. But why does it work? Streets production only grabs layer-groups from the layers-api, afaict.

allthesignals commented 4 years ago

@andycochran I think it may just be that the app pulls from that file locally when you are developing locally. But the change needs to happen in layers API.

hannahkates commented 4 years ago

Closing this. It was handled in labs-layers-api.