search

NYCPlanning / labs-streets

The City Map is the official adopted map of the city. It shows the location, dimension and grades of streets, parks, public places, and certain public easements.
http://streets.planning.nyc.gov
Other
10 stars 0 forks source link

Update netlify.toml and environment.js to use correct Carto instances and remove dead code #342

Closed TylerMatteo closed 1 year ago

TylerMatteo commented 1 year ago

Summary

This PR is meant to address some issues we are having with local development. For reasons that I never quite got to the bottom of, running the project locally with no changes to environment.js would use the files in /public/v1 for configuring the map layers, as stated in the existing README.md. I think this is a relic from before Layers API was built and/or an outdated approach to allow engineers to easily tweak those files to test changes. These changes should align this repo with the approach we have elsewhere like Zola so that:

data-qa Layers API uses the "staging" Carto instance. Other environments use the "production" instance

I removed a few folders from the repo that contained code that looks to be no longer used, particularly the layer groups and sources files in /public.

Changes to the README remove outdated documentation and describe how to use different Layers API environments and Carto instances locally.

netlify[bot] commented 1 year ago

Deploy Preview for labs-streets ready!

Name Link
Latest commit 1c92337068616cb370f4fabcca46111a6af15428
Latest deploy log https://app.netlify.com/sites/labs-streets/deploys/6409371571c91e0008534ee3
Deploy Preview https://deploy-preview-342--labs-streets.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.