NYCPlanning / labs-zap-search

Search application for the DCP Zoning Application Search
https://zap.planning.nyc.gov
13 stars 3 forks source link

Research Sharepoint OAuth conversion #1494

Closed TylerMatteo closed 8 months ago

TylerMatteo commented 9 months ago

Research spike for determining the impact of updating the ZAP Search and Applicant Portal APIs to authenticate to the Sharepoint API with OAuth and new credentials. The output of this spike will either be:

TylerMatteo commented 9 months ago

Assigning to myself for now. Next steps will be a meeting with Ella to ask some questions about why this change is happening and what all is being deprecated.

TylerMatteo commented 9 months ago

Tracking initial discussions and research for this in this discussion

TylerMatteo commented 8 months ago

@TangoYankee @AmandaDoyle I'm closing this as completed because, after a productive conversation with Ella and Bujji, we are in a bit of a holding pattern.

Summary of meeting with CRM team

After we showed how our code uses Sharepoint APIs, Ella and Bujji sounded reasonably confident that we may not have to make any changes to our code at all. Because client ids and secrets will be generated in Azure App Registration instead of Sharepoint Pages, Ella put in a request to the Citywide Service Desk to get our app registered. Once OTI registers the app, Ella can generate new keys for us. Once we have UAT keys, we can create an Issue for someone on AE to test that they slot into our applications without needing to change any code. If that works, we can do the same for prod and be done with this. If it doesn't, we would have to embark on migrating to the newer MS Graph APIs, but we'll cross that bridge if/when we come to it.