search

NYCPlanning / labs-zola

NYC Planning's Zoning and Land Use App
https://zola.planning.nyc.gov
Other
75 stars 26 forks source link

WIP - Upgrade to Ember 4.12 and Node 18 #1146

Closed TylerMatteo closed 8 months ago

TylerMatteo commented 10 months ago

This PR upgrades Zola to Ember 4.12 and Node 18. Posting this now to get help on it but will be including a much more detailed description soon.

The corresponding changes to @nycplanning/ember that are used here are tracked in this PR

netlify[bot] commented 10 months ago

Deploy Preview for labs-zola ready!

Name Link
Latest commit 17b73d75ead4bdba96ff323c7273adf514a020b1
Latest deploy log https://app.netlify.com/sites/labs-zola/deploys/6536bd305d84490008704c3e
Deploy Preview https://deploy-preview-1146--labs-zola.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TylerMatteo commented 9 months ago

@allthesignals Any updates on this?

allthesignals commented 9 months ago

@TylerMatteo I'm seeing tests pass. Do you want me to try to resolve these merge conflicts?

allthesignals commented 9 months ago

I was able to resolve most of the merge conflicts. I want to make sure I didn't accidentally mess up @dhochbaum-dcp's metrics work...

allthesignals commented 9 months ago

@TylerMatteo what do you think is blocking this from merge?

TylerMatteo commented 8 months ago

@TylerMatteo what do you think is blocking this from merge?

We'll chat at our check-in but at this point I think we're just about ready to go. I'll set aside some time to merge and publish that @nycplanning/ember PR. Then I can add one more commit to this PR to get it off of the prerelease version and we'll be good to hand off to QA.

allthesignals commented 8 months ago

@TylerMatteo would also love to revisit getting CI test suite working again. Maybe the upgrades have fixed some things.