search

NYCPlanning / labs-zola

NYC Planning's Zoning and Land Use App
https://zola.planning.nyc.gov
Other
75 stars 26 forks source link

1155 Update ZOLA DTM link #1157

Closed horatiorosa closed 7 months ago

horatiorosa commented 7 months ago

Description

This PR updates the digital tax map link from http://maps.nyc.gov/taxmap/map.htm to http://gis.nyc.gov/taxmap/map.htm in an effort to avoid a 400 on redirect on Chrome browser when redirected to the DOF hosted tax maps

Tickets

Closes #1155

netlify[bot] commented 7 months ago

Deploy Preview for labs-zola ready!

Name Link
Latest commit 7f704bba4fa46c58dac1ee17557f9227f81f7fe8
Latest deploy log https://app.netlify.com/sites/labs-zola/deploys/655e392396c537000877fcc0
Deploy Preview https://deploy-preview-1157--labs-zola.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

horatiorosa commented 7 months ago

@horatiorosa looks good. Because develop has the upgrade changes that are still in QA, please open another PR for this feature branch against master.

I think I would need to open new PR bc unless I have lost my mind, the digitalTaxmapLink function is in /app/models/map-features/lot.js on master, while on develop it's in app/components/layer-record-views/tax-lot.js.

I am assuming some refactoring was done.

I will proceed and make a new PR on a fresh branch from master.

1159