NYCPlanning / labs-zola

NYC Planning's Zoning and Land Use App
https://zola.planning.nyc.gov
Other
77 stars 27 forks source link

Upgrade Cyclomedia API to latest version 18.4 #971

Open croswell81 opened 4 years ago

croswell81 commented 4 years ago

Describe the bug Cyclomedia imagery for the latest capture displays with pixilation around the seams of the imagery

To Reproduce Steps to reproduce the behavior:

  1. Search for a property in Zola
  2. Scroll down and click on the Cyclomedia Street View link to launch the Cyclomedia window
  3. pan around the image to see pixilation

Expected behavior Image should be seamless with no pixilation

Screenshots image

Desktop (please complete the following information):

Additional context Spoke with Cyclomedia and they said upgrading to latest version of API will fix the issue. This is from their website: As of August 29, CycloMedia will use a new way to store Cycloramas. Street Smart and the Street Smart API from version 18.4 onwards are prepared for this update, so there will be no noticeable changes.

allthesignals commented 4 years ago

Thanks @croswell81, great catch!

Relatedly, we made a change to the lot view where the Cyclomedia viewer doesn't embed: https://zola.planning.nyc.gov/l/lot/1/406/24

Have you noticed any performance improvements or any comments from users?

allthesignals commented 2 years ago

The code for this view can be found here: https://github.com/NYCPlanning/labs-cyclomedia-service

allthesignals commented 2 years ago

@croswell81 the Cyclomedia view is handled by another repo linked above. If we can get the mentioned PR (https://github.com/NYCPlanning/labs-cyclomedia-service/pull/2) merged, it will fix the pixelation issue:

17.2:

Screen Shot 2021-10-26 at 4 40 54 PM

18.4:

Screen Shot 2021-10-26 at 4 41 07 PM