search

NYCPython / wheretomeetup

Connecting Meetup organizers with hosts and sponsors.
http://www.wheretomeetup.com
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

A few tests #50

Closed Julian closed 12 years ago

Julian commented 12 years ago

(The branch is named poorly now. Also it appears I failed at rebase again, sigh, so this will need to be cherry picked or manually merged since the tox commit was done in develop.)

Obviously this is nowhere near finished, but I'm starting to push boundaries around, so it's good to get this out there fairly quickly so that we don't run into merge conflicts if you guys are working on the same sections of the code I am.

What's here so far is ideologically focused on taming the hulk that is sync_user as a first thing to tackle, so that's where the tests that are here already are aimed at – making things a bit more testable, so that eventually sync_user can be broken out into little pieces.

There's still some duplication, and tests will be pushed down into lower layers as things pan out, but the next steps are to pull out all that next jumping in sync_user into a helper function by adding a few more tests around that section.

dcrosta commented 12 years ago

It seems to merge fine, save a small conflict in test-requirements.txt. If you're done with this, I can push to develop with the results.

Julian commented 12 years ago

Nice. You can merge what's there if you'd like then, thanks :).

On Wednesday, August 29, 2012, Dan Crosta wrote:

It seems to merge fine, save a small conflict in test-requirements.txt. If you're done with this, I can push to develop with the results.

— Reply to this email directly or view it on GitHubhttps://github.com/NYCPython/wheretomeetup/pull/50#issuecomment-8122362.