search

NYPL-Simplified / circulation

Circulation manager for Library Simplified
Other
19 stars 19 forks source link

Fix Build API Documentation action #1809

Closed keithbauer closed 2 years ago

keithbauer commented 2 years ago

Description

Fix errors that cause the Build API Documentation action to fail.

Motivation and Context

When webpub_manifest_parser was folded into core/util this caused the API documentation builds to fail.

How Has This Been Tested?

In the webapp container in the docs folder running make clean && make html until build succeeded.

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Base: 92.57% // Head: 92.57% // No change to project coverage :thumbsup:

Coverage data is based on head (8176b44) compared to base (7a2a9ef). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1809 +/- ## ======================================== Coverage 92.57% 92.57% ======================================== Files 215 215 Lines 43514 43514 ======================================== Hits 40283 40283 Misses 3231 3231 ``` | [Impacted Files](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [api/lcp/collection.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2xjcC9jb2xsZWN0aW9uLnB5) | `94.44% <ø> (ø)` | | | [api/lcp/mirror.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2xjcC9taXJyb3IucHk=) | `87.30% <ø> (ø)` | | | [core/mirror.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS9taXJyb3IucHk=) | `91.04% <ø> (ø)` | | | [core/monitor.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS9tb25pdG9yLnB5) | `97.42% <ø> (ø)` | | | [core/opds\_import.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS9vcGRzX2ltcG9ydC5weQ==) | `93.87% <ø> (ø)` | | | [core/s3.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS9zMy5weQ==) | `97.57% <ø> (ø)` | | | [core/util/webpub\_manifest\_parser/core/ast.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS91dGlsL3dlYnB1Yl9tYW5pZmVzdF9wYXJzZXIvY29yZS9hc3QucHk=) | `91.50% <ø> (ø)` | | | [...ore/util/webpub\_manifest\_parser/core/properties.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS91dGlsL3dlYnB1Yl9tYW5pZmVzdF9wYXJzZXIvY29yZS9wcm9wZXJ0aWVzLnB5) | `90.07% <ø> (ø)` | | | [scripts.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-c2NyaXB0cy5weQ==) | `66.33% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.