NYPL-Simplified / circulation

Circulation manager for Library Simplified
Other
19 stars 19 forks source link

SIMPLY-4216 Fix: Use the library from the patron's root_lane #1823

Closed keithbauer closed 2 years ago

keithbauer commented 2 years ago

Description

Use the library from the patron's root_lane instead of getting it from the authenticator. This is more reliable and cleaner than getting it from the authenticator since the library is already tied to the root_lane if one exists.

Motivation and Context

SIMPLY-4216

How Has This Been Tested?

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Base: 92.57% // Head: 92.57% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (5adbde6) compared to base (3896a26). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1823 +/- ## =========================================== - Coverage 92.57% 92.57% -0.01% =========================================== Files 215 215 Lines 43526 43525 -1 =========================================== - Hits 40295 40294 -1 Misses 3231 3231 ``` | [Impacted Files](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [api/authenticator.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1823/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2F1dGhlbnRpY2F0b3IucHk=) | `96.56% <ø> (-0.01%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.