NYPL-Simplified / circulation

Circulation manager for Library Simplified
Other
19 stars 19 forks source link

Remove delete method from endpoint #1826

Closed thinkwebengineer closed 2 years ago

thinkwebengineer commented 2 years ago

Description

Remove deprecated DELETE method to /loans/<identifier_type>/<path:identifier> end point.

Motivation and Context

Found a method that has not been declared and removed it.

How Has This Been Tested?

No testing required. The method was never declared in the code.

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Base: 92.49% // Head: 92.49% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (4e77305) compared to base (2771ce8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1826 +/- ## ======================================== Coverage 92.49% 92.49% ======================================== Files 216 216 Lines 43609 43607 -2 ======================================== Hits 40335 40335 + Misses 3274 3272 -2 ``` | [Impacted Files](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [api/controller.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1826/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2NvbnRyb2xsZXIucHk=) | `90.75% <ø> (+0.14%)` | :arrow_up: | | [api/routes.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1826/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL3JvdXRlcy5weQ==) | `90.85% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.