NYPL-Simplified / circulation

Circulation manager for Library Simplified
Other
19 stars 19 forks source link

Clever v3 take 2 #1840

Closed thinkwebengineer closed 1 year ago

thinkwebengineer commented 1 year ago

Description

Update Clever tests and schemes to v3.0

Motivation and Context

To upgrade to v3.0 before deprecation of v1.1

How Has This Been Tested?

Existing tests pass, but this is difficult to test locally. And will need to be confirmed on qa.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.55% // Head: 92.56% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (c4df53e) compared to base (4237315). Patch coverage: 93.51% of modified lines in pull request are covered.

:exclamation: Current head c4df53e differs from pull request most recent head 0d2894a. Consider uploading reports for the commit 0d2894a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1840 +/- ## ======================================== Coverage 92.55% 92.56% ======================================== Files 216 216 Lines 43597 43619 +22 ======================================== + Hits 40351 40375 +24 + Misses 3246 3244 -2 ``` | [Impacted Files](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [api/controller.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2NvbnRyb2xsZXIucHk=) | `90.75% <85.29%> (+0.21%)` | :arrow_up: | | [api/clever/\_\_init\_\_.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2NsZXZlci9fX2luaXRfXy5weQ==) | `95.23% <85.71%> (-1.71%)` | :arrow_down: | | [api/authenticator.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2F1dGhlbnRpY2F0b3IucHk=) | `96.58% <100.00%> (+0.05%)` | :arrow_up: | | [api/novelist.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL25vdmVsaXN0LnB5) | `96.71% <100.00%> (+0.03%)` | :arrow_up: | | [api/routes.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL3JvdXRlcy5weQ==) | `90.85% <100.00%> (ø)` | | | [api/base\_controller.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2Jhc2VfY29udHJvbGxlci5weQ==) | `88.05% <0.00%> (+1.49%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.