codecov[bot]
commented
1 year ago Codecov Report
Base: 92.56% // Head: 92.56% // No change to project coverage :thumbsup:
Coverage data is based on head (
594c0cc) compared to base (466bc7f). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #1857 +/- ## ======================================== Coverage 92.56% 92.56% ======================================== Files 216 216 Lines 43631 43631 ======================================== Hits 40386 40386 Misses 3245 3245 ``` | [Impacted Files](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [core/model/\_\_init\_\_.py](https://codecov.io/gh/NYPL-Simplified/circulation/pull/1857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS9tb2RlbC9fX2luaXRfXy5weQ==) | `94.26% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Description
Add
pool_recyclethat invalidates connections older than 30 minutes upon checking out a connection (open to any value for this if we feel 30 minutes isn't a good fit). SQLAlchemy docs.Motivation and Context
SIMPLY-4243 Implement a potential solution from SIMPLY-4221 and monitor for any changes.
How Has This Been Tested?
Tested locally with tests, but to see any real impact this will need to be deployed.
Checklist: