NYPL-Simplified / circulation

Circulation manager for Library Simplified
Other
19 stars 19 forks source link

OE-929 patron is new #1884

Closed keithbauer closed 1 year ago

keithbauer commented 1 year ago

Description

Adds a new parameter, is_new, for Clever and FirstBook (through the basic auth temp token) that denotes if this is the first time the database is seeing this patron.

Motivation and Context

OE-929 Pass along a status indicator if a we're seeing a patron for the first time in our database.

How Has This Been Tested?

Updated unit tests to check for is_new.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 92.30% and project coverage change: -0.01 :warning:

Comparison is base (734566a) 92.56% compared to head (b99e6e7) 92.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1884 +/- ## =========================================== - Coverage 92.56% 92.55% -0.01% =========================================== Files 216 216 Lines 43632 43645 +13 =========================================== + Hits 40386 40397 +11 - Misses 3246 3248 +2 ``` | [Impacted Files](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [api/authenticator.py](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2F1dGhlbnRpY2F0b3IucHk=) | `96.51% <90.90%> (-0.07%)` | :arrow_down: | | [api/clever/\_\_init\_\_.py](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2NsZXZlci9fX2luaXRfXy5weQ==) | `97.32% <100.00%> (+0.04%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1884/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.