NYPL-Simplified / circulation

Circulation manager for Library Simplified
Other
19 stars 19 forks source link

OE-929 patron is_new (OAuth) #1893

Closed keithbauer closed 1 year ago

keithbauer commented 1 year ago

Description

Explicitly passes along the url parameteris_new=<true|false> for Clever/OAuth.

Motivation and Context

OE-929 Fixes the is_new parameter missing for Clever

How Has This Been Tested?

Updated test_oauth_authentication_callback to check that is_new is in the url which pulls from PatronData.is_new.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@01856a8). Click here to learn what that means. Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1893 +/- ## ========================================== Coverage ? 92.56% ========================================== Files ? 216 Lines ? 43648 Branches ? 0 ========================================== Hits ? 40401 Misses ? 3247 Partials ? 0 ``` | [Impacted Files](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1893?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [api/authenticator.py](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1893?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2F1dGhlbnRpY2F0b3IucHk=) | `96.52% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.