codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
9b92207) 92.56% compared to head (32605c5) 92.56%. Report is 15 commits behind head on develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #1901 +/- ## ======================================== Coverage 92.56% 92.56% ======================================== Files 216 216 Lines 43647 43648 +1 ======================================== + Hits 40400 40401 +1 Misses 3247 3247 ``` | [Files Changed](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified) | Coverage Δ | | |---|---|---| | [core/scripts.py](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-Y29yZS9zY3JpcHRzLnB5) | `86.48% <ø> (ø)` | | | [api/authenticator.py](https://app.codecov.io/gh/NYPL-Simplified/circulation/pull/1901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NYPL-Simplified#diff-YXBpL2F1dGhlbnRpY2F0b3IucHk=) | `96.52% <100.00%> (+<0.01%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This update introduces two configuration settings for our gunicorn server:
max_requestsLimits the number of total requests that can be handled by a single gunicorn worker. The gunicorn docs state this is intended to help limit effects of memory leaksmax_requests_jitterThis randomizes the exact number of requests to prevent multiple workers from being restarted simultaneouslyThe goal of this work is to hopefully limit memory consumption (which tends to run at 90% or greater in production) and to reduce the effect of
QueuePoolerrors that result from long-running workers. At the current setting of 500 this should result in workers being restarted roughly every 45-60 minutes. This can be adjusted after review of effects on performance in QA (and production if no issues are raised in QA).