search

NYPL-Simplified / server_core

Shared data model and utilities for Library Simplified server applications
7 stars 11 forks source link

Add OPDS 2.0 import support #1205

Closed vbessonov closed 3 years ago

vbessonov commented 3 years ago

Description

This PR adds OPDS 2.0 support to Circulation Manager:

Motivation and Context

SIMPLY-2901

How Has This Been Tested?

Checklist:

leonardr commented 3 years ago

This is looking pretty good and since this is critical path for you, and not for me, I'm fine if you want to merge it before addressing everything I mentioned.

The only things I'd really like to see resolved before the merge are the imprint thing and the assignment of roles to Contributors based on which collection they were in in the OPDS 2 feed. Those are the two items where if you import a feed using the current code, you'd probably want to delete the collection and re-import it after improving this code.

vbessonov commented 3 years ago

@leonardr, I fixed most of the issues

vbessonov commented 3 years ago

@leonardr, yes, I think it's ready to merge now. I'll working on a new PR adding a ProQuest integration, if anything missing I'll add it there

vbessonov commented 3 years ago

@leonardr, I updated the new MARC codes