search

NYPL-Simplified / server_core

Shared data model and utilities for Library Simplified server applications
7 stars 11 forks source link

Address nits from #1222 #1223

Closed jonathangreen closed 3 years ago

jonathangreen commented 3 years ago

Here is a small PR to address the nits from @tdilauro on #1222

There is a lot of noise in the diff, but its all just moving around imports. This is the result from running PyCharm's "optimize imports" which is supposed to follow Python's PEP 8 section on import style.

vbessonov commented 3 years ago

What do you think about using isort to sort and optimize imports?

leonardr commented 3 years ago

I think running isort on this code for a one-time fix is a good start towards instituting something more automated. We did something similar a while ago to remove trailing spaces at the end of lines.