Fix OPDS importer to handle improved DPLA/Feedbooks OPDS 1.x+ODL feed - Githubissues

NYPL-Simplified / server_core

Shared data model and utilities for Library Simplified server applications

7 stars 11 forks source link

Fix OPDS importer to handle improved DPLA/Feedbooks OPDS 1.x+ODL feed #1227

Closed arielmorelli closed 3 years ago

arielmorelli commented 3 years ago

Description

This PR add:

the possibility of use the \<dcterm:identifier> instead of \<id>
use custom accept header instead of the system default

Motivation and Context

How Has This Been Tested?

New unit tests were add.
Was used the real Feedbook XML URL for tests: https://market.feedbooks.com/api/libraries/harvest.atom
To run the database, elasticsearch and minio were used in a docker-compose environment. The complete env can be found here

Checklist:

[ ] I have updated the documentation accordingly.
[X] All new and existing tests passed.

arielmorelli commented 3 years ago

@leonardr can you check again, please? I resolved everything we talked about in this PR.