Closed EdwinGuzman closed 3 years ago
I haven't finished walking through the whole PR yet, I wanted to add some comments but accidentally submitted an approval.
This PR now includes the pytest
update done by @jonathangreen . I switched from python 2.7 to python 3.6 in the tox.ini
file and updated a few files with minor updates (the biggest/tedious part of this was fixing merge conflicts).
Fixes SIMPLY-2215.
The goal for this is to fully convert the codebase to python 3 (3.6 which seems stable on Travis). This is used as a git submodule so Docker is not needed for this repo.
2to3
.TODO python3
commentssix
andfutures
.native_string
helper function.urlparse
tourllib.parse
.metaclass
is declared.None
and it was expecting a number.tounicode
totostring
and slightly updated the call for the updated package version.Missing todos:
marc_record
Work
column to binary strings. Moving fromString
toBinary
in the database works but as discussed with Leonard, this may be a big migration.Although this PR is using python 3, there are still updates I discussed with @nballenger that are not part of this PR but want to include in subsequent PRs such as: