NYPL-Simplified / server_core

Shared data model and utilities for Library Simplified server applications
7 stars 11 forks source link

Python 3 Update #1244

Closed EdwinGuzman closed 3 years ago

EdwinGuzman commented 3 years ago

Fixes SIMPLY-2215.

The goal for this is to fully convert the codebase to python 3 (3.6 which seems stable on Travis). This is used as a git submodule so Docker is not needed for this repo.

Missing todos:

Although this PR is using python 3, there are still updates I discussed with @nballenger that are not part of this PR but want to include in subsequent PRs such as:

vbessonov commented 3 years ago

I haven't finished walking through the whole PR yet, I wanted to add some comments but accidentally submitted an approval.

EdwinGuzman commented 3 years ago

This PR now includes the pytest update done by @jonathangreen . I switched from python 2.7 to python 3.6 in the tox.ini file and updated a few files with minor updates (the biggest/tedious part of this was fixing merge conflicts).