Closed tdilauro closed 3 years ago
I pulled this back into draft to prevent it getting merged before I look into an inconsistent test result in circulation
based on this PR.
@leonardr I was able to move the prefix into a the logger. So, this is set from my perspective, pending your review.
Description
This branch makes some enhancements focused on collection monitors. At the highest level, these changes allow us to:
Here's a little more detail:
CollectionMonitor.all
method now takes acollections
parameter to help its (mostly script runner) collaborators control which collections will have monitors generated for them.RunCollectionMonitorScript
s now parses arguments during initialization and accepts zero or more collection names. Those names are transformed to their associated collections and passed on toCollectionMonitor.all
.Motivation and Context
https://jira.nypl.org/browse/SIMPLY-3416
How Has This Been Tested?
Tested some existing monitors to verify that the new collection name details were present in log messages. Created new tests and, in addition to running this repo's test suite, I ran that of the current
circulation
repodevelop
branch withcore
updated to thisserver_core
commit.Checklist: