NYPL-Simplified / server_core

Shared data model and utilities for Library Simplified server applications
7 stars 11 forks source link

Feature/collection monitor command line args #1254

Closed tdilauro closed 3 years ago

tdilauro commented 3 years ago

Description

This branch makes some enhancements focused on collection monitors. At the highest level, these changes allow us to:

Here's a little more detail:

Motivation and Context

https://jira.nypl.org/browse/SIMPLY-3416

How Has This Been Tested?

Tested some existing monitors to verify that the new collection name details were present in log messages. Created new tests and, in addition to running this repo's test suite, I ran that of the current circulation repo develop branch with core updated to this server_core commit.

Checklist:

tdilauro commented 3 years ago

I pulled this back into draft to prevent it getting merged before I look into an inconsistent test result in circulation based on this PR.

tdilauro commented 3 years ago

@leonardr I was able to move the prefix into a the logger. So, this is set from my perspective, pending your review.