NYPL-Simplified / server_core

Shared data model and utilities for Library Simplified server applications
7 stars 11 forks source link

Handle the case where there are multiple items in heaviest_child. #1270

Closed leonardr closed 2 years ago

leonardr commented 2 years ago

This PR fixes https://jira.nypl.org/browse/SIMPLY-3858 by changing the way a sequence of (GenreData : (GenreData, int)) tuples is sorted. GenreData objects aren't comparable, so the correct solution is to sort by the ints.

nballenger commented 2 years ago

Colon went missing after a for loop, pushed up a commit that put it back to hopefully get the tests running successfully.