Add xicon #94 - Githubissues

NYPL-Simplified / webpub-viewer

8 stars 4 forks source link

Closed ricardoom closed 7 years ago

ricardoom commented 7 years ago

fixes #94

aslagle commented 7 years ago

I want to write some more tests before we merge this.

ricardoom commented 7 years ago

getting merge conflicts too... I'll see about fixing

ricardoom commented 7 years ago

werid. no merge conflicts locally...

aslagle commented 7 years ago

I added most of the tests I wanted but I couldn't get keyboard focus to work in tests so there's still nothing for that.

ricardoom commented 7 years ago

@aslagle cool...

aslagle commented 7 years ago

@ricardoom I made one more tiny change, could you make sure it still looks ok?

ricardoom commented 7 years ago

👁

ricardoom commented 7 years ago

I think all is well here. ready to merge.