NYPL-Simplified / webpub-viewer

8 stars 4 forks source link

Config object arguments and configurable static file URLs for service worker to cache #107

Closed aslagle closed 7 years ago

aslagle commented 7 years ago

This fixes #54 This fixes #104

When I started minifying JS and CSS, I broke the service worker caching because I had hard-coded file names to be cached on install in the service worker itself. I moved all of those to an argument that gets passed into the service worker cacher instead so they can be configurable without having to modify the built service worker file. Since I was adding an argument I decided to go ahead and do #54 as well.

I don't actually want to merge this into add-xicon-#94, but it's easier to review that way. I'll change this to go to master once that branch is done.