Update page navigation buttons

NYPL-Simplified / webpub-viewer

8 stars 4 forks source link

Update page navigation buttons #168

Closed M0nica closed 3 years ago

M0nica commented 3 years ago

Show page navigation buttons when Table of Contents is inactive
Hide page navigation buttons when Table of Contents is active (in order to resolve issue with page navigation buttons overlapping with the table of contents)

EdwinGuzman commented 3 years ago

The code looks good but I'm not sure how to manually test it. Just run the app, right?

M0nica commented 3 years ago

The code looks good but I'm not sure how to manually test it. Just run the app, right?

@EdwinGuzman Yep, you can manually test by:

running the build command and then the static command.
Opening static app and click on Call of The Wild (Note: The app runs on https).
Test what happens to page navigation when the table of contents and open/closed and also test that other parts of the reader do not cause the page navigation to shift or change unexpectedly.

hokei commented 3 years ago

Seems like there's been a regression where if you move to narrow screen, turn on the TOC, move to wide screen, turn off TOC, the reader is in a weird state. I'm not able to reproduce this on SFR-develop

hokei commented 3 years ago

but everything else looks good to me

M0nica commented 3 years ago

but everything else looks good to me

@hokei I just updated the branch. I believe switching from display: none to visibility:hidden for flip-page-container.hidden resolves this issue.