search

NYPL-Simplified / webpub-viewer

8 stars 4 forks source link

Chapter Title Parsing #175

Closed hokei closed 3 years ago

hokei commented 3 years ago

I filed https://jira.nypl.org/browse/SIMPLY-3186 as a follow up This only deals with the most surface of the issues, there are a bunch of underlying issues that may need fixing in the future. The good news is that it shouldn't have broken anything already working. The bad news is that I'm punting the writing of unit tests on this in favor of finishing up features by Wednesday.

kristojorg commented 3 years ago

I'm getting two errors on the config branch when trying to run this: cannot read href of undefined and cannot read length of undefined. I tried clearing my browser data to no avail :/

kristojorg commented 3 years ago

Also wtf IFrameNavigator.ts is 1700 lines?! I wish I didn't see that

hokei commented 3 years ago

Also wtf IFrameNavigator.ts is 1700 lines?! I wish I didn't see that

:trash_fire_emoji:

hokei commented 3 years ago

Some books don't have the TOC in the header, but presumably that's because they're not compatible

Yeah in my initial survey I thought most of the books were epub3 but it turns out a bunch of them aren't. I'll add them in next week.