search

NYPL-Simplified / webpub-viewer

8 stars 4 forks source link

showing / hiding in css? #60

Closed ricardoom closed 7 years ago

ricardoom commented 7 years ago

is it possible to remove the inline showing /hiding on these two lines: https://github.com/NYPL-Simplified/webpub-viewer/blob/master/src/IFrameNavigator.ts#L77 https://github.com/NYPL-Simplified/webpub-viewer/blob/master/src/IFrameNavigator.ts#L78 and just have it controlled purely w/ css?

aslagle commented 7 years ago

probably - the active/inactive classes could control it. would that be helpful?

ricardoom commented 7 years ago

i think so. maybe we can make a branch to explore it.

aslagle commented 7 years ago

Started this branch https://github.com/NYPL-Simplified/webpub-viewer/tree/show-hide-with-css

I'll need to fix tests later if we stick with it.

ricardoom commented 7 years ago

great. thanks. I'll probably have to work on it tonight.