search

NYPL-Simplified / webpub-viewer

8 stars 4 forks source link

Design improvements #84

Closed ricardoom closed 7 years ago

ricardoom commented 7 years ago

fixes #79

aslagle commented 7 years ago

This happened when I clicked scrolling...

screen shot 2017-05-02 at 10 30 42 am
aslagle commented 7 years ago

Also the alignment of the font label message is a little off when you increase the size.

screen shot 2017-05-02 at 10 33 47 am
ricardoom commented 7 years ago

regarding the first screen shot, I'm not seeing that breaking of the controls to the next line... regarding the second, i'll fix that. I'll pull this pr.

ricardoom commented 7 years ago

@aslagle I made the .fontSizeLabel fixed so we dont have such a jumpy experience when resizing the type size...

ricardoom commented 7 years ago

checks failing due to commented code, not sure how to modify those tests...

aslagle commented 7 years ago

@ricardoom I think you could put back most of the code, and then delete the one test that checks if the font size label changes size.

ricardoom commented 7 years ago

ok. will do.

On May 2, 2017, at 12:07, Amy Slagle notifications@github.com wrote:

@ricardoom I think you could put back most of the code, and then delete the one test that checks if the font size label changes size.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ricardoom commented 7 years ago

@aslagle can it be dug?