NYPL-discovery / discovery-models

Data models, documentation, and discussion for Discovery project data
0 stars 0 forks source link

Partial shelfmarks #49

Open seanredmond opened 7 years ago

seanredmond commented 7 years ago

Looking at National Geographic http://dev-discovery.nypl.org/research/collections/discovery-beta/bib/b10218721?itemPage=2 some items are missing the volume and date portion of their shelfmark. For instance, the first one like this on the list, item i29211348, only has "JFM 74-400" but looking at Sierra (https://catalog.nypl.org/search~S1?/.b10218721/.b10218721/1,1,1,B/holdings~10218721&FF=&1,0,) it should be "JFM 74-400 v. 19 (July-Dec. 1908)"

saverkamp commented 7 years ago

I can't seem to access any of the items w/o the volume/date through the API. However, I can access the ones with the volume/date. Maybe that's part of the problem? Guessing these items didn't get fully serialized for one reason or another?

saverkamp commented 7 years ago

(If you're able to find one of the items in the API, can you send me the raw data, so I can see if it's mapped correctly?)

seanredmond commented 7 years ago

How are you accessing the items? I only see how to get bibs

saverkamp commented 7 years ago

Through the items endpoint in the swagger interface.

seanredmond commented 7 years ago

@kfriedman @jobinthomasnypl This is what Shawn and I were talking about at standup