search

NYPL / ami-tools

MIT License
14 stars 6 forks source link

add general json hash fixer #72

Closed genfhk closed 1 year ago

nkrabben commented 2 years ago

this is a super good fix, but i think there's some help text to fix on another tool. Can you tack that onto this branch?

bturkus commented 2 years ago

what does this do exactly? I can't tell from the code

nkrabben commented 2 years ago

It fixes a bug I introduced when I added nargs to -b It also adds a new flag to the json fixer. Previously this tool programmatically fixed two common areas and then updated the bag manifests, etc. Now, if you altered json without this tool, you can run with --badjson and it will update the bag manifests, etc.

genfhk commented 2 years ago

this is a super good fix, but i think there's some help text to fix on another tool. Can you tack that onto this branch?

done with 846fc8d - can you review?

bturkus commented 1 year ago

@nkrabben is this what we were discussing earlier today?