NYPL / discovery-api

Discovery API: the JSON-LD API supporting NYPL Shared Collection Catalog
MIT License
6 stars 0 forks source link

add m1 requestability - WIP #331

Closed charmingduchess closed 1 year ago

charmingduchess commented 1 year ago

A lot went down:

The code has LOTS of unit tests, many of which I've moved around as I've moved parts of the code around. A bunch of the tests in requestability_resolver.test.js came from availabilityResolver, for example. I think even before looking at the code, it would be most useful to go through the test cases and check that the output is in line with our business logic.

NB: To run the tests, run NYPL_CORE_VERSION=romcom-2.0-prerelease npm test

Not in this PR:

nonword commented 1 year ago

Also, does this work depend on @nypl/nypl-core-objects v1.6.1?