This fixes an issue where item sorting is not working correctly in DFE
Why are we doing this? (w/ JIRA link if applicable)
We noticed a discrepancy in item sorting in DFE and research catalog and it turns out this is broken in DFE.
The problem was caused by the itemWithSortableShelfMark (which generates the sort string) invoking shelfMark and uri which are not set in the output of mapItems. I replaced shelfMark with callNumber and output the uri attribute to fix the issue.
Do these changes have automated tests?
No
How should this be QAed?
Item sorting should match that of research-catalog.
What's this do? Ticket: https://jira.nypl.org/browse/SCC-3923
This fixes an issue where item sorting is not working correctly in DFE
Why are we doing this? (w/ JIRA link if applicable) We noticed a discrepancy in item sorting in DFE and research catalog and it turns out this is broken in DFE.
The problem was caused by the itemWithSortableShelfMark (which generates the sort string) invoking shelfMark and uri which are not set in the output of mapItems. I replaced shelfMark with callNumber and output the uri attribute to fix the issue.
Do these changes have automated tests? No
How should this be QAed? Item sorting should match that of research-catalog.