NYPL / discovery-front-end

Discovery front-end app
https://www.nypl.org/research/research-catalog/
0 stars 0 forks source link

TGR-50: Remediation update #2155

Closed EdwinGuzman closed 1 week ago

EdwinGuzman commented 3 months ago

NOTE: Tests currently DO NOT run. This might be the tradeoff we deal with now or spend a week or so updating tests to jest/rtl for Hold and SHEP pages (since those are/will be left in the app until the refactor project is complete).

~This is still a WIP because we are waiting on tech stacks but~ please test locally. Make sure you have AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY set in .env for the Docker image to build correctly.

1.9.0

Remediation Project Update

Adds

Updates

Removals

EdwinGuzman commented 2 months ago

Good point, thanks, I'll remove the commented code.

charmingduchess commented 2 months ago

@EdwinGuzman are there specs for this work? the ticket seems to be more documentation of the work itself than a directive describing what needs to happen.

charmingduchess commented 2 months ago

per our discussion, please update the readme to indicate the --force flag for npm i invocation

EdwinGuzman commented 1 month ago

This update is on the QA, Train, and Production live envs. Merging into development with the known issue of tests failing.