Closed EdwinGuzman closed 1 week ago
Good point, thanks, I'll remove the commented code.
@EdwinGuzman are there specs for this work? the ticket seems to be more documentation of the work itself than a directive describing what needs to happen.
per our discussion, please update the readme to indicate the --force
flag for npm i
invocation
This update is on the QA, Train, and Production live envs. Merging into development
with the known issue of tests failing.
NOTE: Tests currently DO NOT run. This might be the tradeoff we deal with now or spend a week or so updating tests to jest/rtl for Hold and SHEP pages (since those are/will be left in the app until the refactor project is complete).
~This is still a WIP because we are waiting on tech stacks but~ please test locally. Make sure you have
AWS_ACCESS_KEY_ID
andAWS_SECRET_ACCESS_KEY
set in.env
for the Docker image to build correctly.1.9.0
Remediation Project Update
Adds
AWS_ACCESS_KEY_ID
andAWS_SECRET_ACCESS_KEY
as example env vars needed in.env-sample
. They are required for building Docker images.Dockerfile
and instructions on how to use it locally.sass
,webpack-dev-middleware
Updates
.nvmrc
to use Node 20.build
anddev
.react-number-format
package is used in theFieldsetDate
component.focus-trap-react
package.@babel/preset-env
,@babel/preset-react
,@babel/preset-register
,@nypl/nypl-core-objects
,@nypl/nypl-data-api-client
,@typescript-eslint/eslint-plugin
,axios
,babel-plugin-module-resolver
,body-parser
,chai
,clean-webpack-plugin
,compression
,cookie-parser
,cross-env
,css-loader
,doctoc
,dotenv
,ejs
,enzyme-adapter-react-16
,eslint
,eslint-config-airbnb
,eslint-config-prettier
,eslint-plugin-import
,eslint-plugin-jsx-a11y
,eslint-plugin-prettier
,eslint-plugin-react
,eslint-plugin-react-hooks
,express
,file-loader
,focus-trap-react
,jsonwebtoken
,mini-css-extract-plugin
,mocha
,mock-local-storage
,nock
,react
,react-autosuggest
,react-dom
,react-number-format
,react-redux
,redux
,redux-thunk
,prettier
,sass-loader
,sinon
,sinon-chai
,style-loader
,supertest
,typescript
,webpack
,webpack-cli
,winston
,underscore
,url-parse
,validator
Removals
.ebextensions
folder since this repos should no longer deploy to ElasticBeanstalk..travis.yml
file to not use Travis CI.Procfile
since this we don't use Heroku.@babel/core
,@babel/polyfill
,@nypl/dgx-header-component
,@nypl/dgx-react-footer
,@typescript-eslint/parser
,node-sass
,node-sass-glob-importer
,react-router-scroll
,webpack-bundle-analyzer
,webpack-dev-server
,webpack-merge