search

NYPL / metronome

UX team documentation microsite.
http://themetronome.co/
0 stars 4 forks source link

Figma Embed Code - File does not show up fully sometime #12

Open ellenlicoffee opened 4 years ago

ellenlicoffee commented 4 years ago

need to find out what is the underlying issue and have it fix

scooooooooby commented 4 years ago

I think a good solution here would be for the Figma iframe to have a red border if unloaded, and a green if it has loaded.

Closing this issue out includes creating those CSS classes and using the Figma API to determine the hooks for when each class gets applied.

Marking this as a bug as it's concerning that Figma sometimes silently fails like this.

ellenlicoffee commented 4 years ago

just catch up on the email. would be nice if it just load with no issue

if they are at loading state a loading bar on top of the frame would help navigate the user.

On Thu, Aug 15, 2019 at 11:20 AM Helen V. Holmes notifications@github.com wrote:

I think a good solution here would be for the Figma iframe to have a red border if unloaded, and a green if it has loaded.

Closing this issue out includes creating those CSS classes and using the Figma API to determine the hooks for when each class gets applied.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NYPL/nypl-design-system-docs/issues/12?email_source=notifications&email_token=AM4QV24ZB4GZG4ZTU577TULQEVX2RA5CNFSM4IL62SH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MDLMA#issuecomment-521680304, or mute the thread https://github.com/notifications/unsubscribe-auth/AM4QV25FKCMNLHYLELIHQOTQEVX2RANCNFSM4IL62SHQ .