Closed EdwinGuzman closed 5 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nypl-design-system | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 16, 2024 2:39pm |
Fixes JIRA ticket DSD-1741
This PR does the following:
useScrollTabIntoView
hook but when attempted, it did not make sense to introduce state to keep track of the focused element. Also, this meant we'd have to check track of user key presses for the tab press and check if a checkbox was focused. This seemed like overengineering a solution.MultiSelect
orAccordion
issue but rather an issue with how theCheckbox
is positioned. Addingposition: "relative"
fixed the root of the issue.How has this been tested?
Review
MultiSelect
,Accordion
(last few stories), andCheckboxGroup
to verify that visually and functionally, everything is working as expected.Accessibility concerns or updates
Checklist:
Front End Review: