No ref: Adding span to Searchbar text - Githubissues

NYPL / nypl-design-system

React design system putting accessibility first.

https://nypl.github.io/nypl-design-system/reservoir/v3/?path=/docs/welcome--docs

Apache License 2.0

39 stars 6 forks source link

No ref: Adding span to Searchbar text #1644

Closed 7emansell closed 1 month ago

7emansell commented 1 month ago

This PR does the following:

Adds a <span> around the button text "Search", allows easier removal on mobile for DCF. Stopgap until component is updated

How has this been tested?

Accessibility concerns or updates

Accessibility Checklist

[x] Checked Storybook's "Accessibility" tab for color contrast and other issues.
[x] The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
[x] For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
[x] For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
[x] The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

[x] I have updated the Storybook documentation and changelog accordingly.
[x] I have added relevant accessibility documentation for this pull request.
[x] All new and existing tests passed.

Front End Review:

[x] Review the Vercel preview deployment once it is ready.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nypl-design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2024 2:32pm