Closed 7emansell closed 3 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nypl-design-system | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 22, 2024 3:27pm |
@bigfishdesign13 Sorry I misunderstood our conversation– if we are not doing mobile updates for the Searchbar
is any of this needed? None of this will be helpful to DC right now (besides adding the span element) but it does move the DS a step closer to what's in the designs for DC, and once all breakpoints align we can definitely use this
Fixes JIRA ticket DSD-1811.
This PR does the following:
Searchbar
(no stacking on mobile)<span>
to "Search" text so DCF can use new breakpointsHow has this been tested?
Accessibility concerns or updates
Accessibility Checklist
aria-live
is used, a screenreader was used to verify the text is read.ref
s, focus management was reviewed.Open Questions
Checklist:
Front End Review: