NYPL / nypl-design-system

React design system putting accessibility first.
https://nypl.github.io/nypl-design-system/reservoir/v3/?path=/docs/welcome--docs
Apache License 2.0
71 stars 6 forks source link

DSD-1733: Adds defaultValue prop to Select #1651

Closed oliviawongnyc closed 3 months ago

oliviawongnyc commented 3 months ago

Fixes JIRA ticket DSD-1733.

This PR does the following:

How has this been tested?

Accessibility concerns or updates

Accessibility Checklist

Open Questions

-

Checklist:

Front End Review:

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 7:26pm
oliviawongnyc commented 3 months ago

Looks good. Just make sure to add defaultValue (and placeholder) to the args object for the WithControls story in order to properly alphabetize the props in the ArgTypes table.

@bigfishdesign13 good catch! updated!