DSD-1836: better overflow styles for Template - Githubissues

NYPL / nypl-design-system

React design system putting accessibility first.

https://nypl.github.io/nypl-design-system/reservoir/v3/?path=/docs/welcome--docs

Apache License 2.0

71 stars 6 forks source link

DSD-1836: better overflow styles for Template #1675

Closed bigfishdesign13 closed 2 months ago

bigfishdesign13 commented 2 months ago

Fixes JIRA ticket DSD-1836

This PR does the following:

Updates the styles for the Template component to use display and overflow for the primary content area to better accommodate the horizontal scrolling in the Table component.

How has this been tested?

locally

Accessibility concerns or updates

n/a

Accessibility Checklist

[ ] Checked Storybook's "Accessibility" tab for color contrast and other issues.
[ ] The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
[ ] For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
[ ] For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
[ ] The feature works when the page is zoomed in to 200% and 400%.

Open Questions

-

Checklist:

[ ] I have updated the Storybook documentation and changelog accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nypl-design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2024 4:30pm