NYPL / nypl-design-system

React design system putting accessibility first.
https://nypl.github.io/nypl-design-system/reservoir/v3/?path=/docs/welcome--docs
Apache License 2.0
71 stars 6 forks source link

[POC] DSD-1851: Updates `Template` to be more responsive using grid #1691

Open oliviawongnyc opened 1 month ago

oliviawongnyc commented 1 month ago

Fixes JIRA ticket DSD-1851

This PR does the following:

How has this been tested?

Accessibility concerns or updates

Accessibility Checklist

Open Questions

-

Checklist:

Front End Review:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:25pm
github-actions[bot] commented 1 month ago

Your pull request is missing a changelog—was that intentional?

oliviawongnyc commented 1 month ago

Just some notes. It's not a perfect pixel-to-pixel update but as a POC it's coming along nicely.

@EdwinGuzman, pixel perfect compared to what? Marty's PR or what we have now? It shouldn't be pixel perfect compared to what we have now given it includes a responsive sidebar, padding, and gaps.

EdwinGuzman commented 1 month ago

pixel perfect compared to what?

To what we have now. There are some changes but I think this difference is crucial -- the alignment of the content:

Screenshot 2024-10-28 at 12 08 38 PM

In prod, the "Content Top" and "Content Primary" align with the Hero. I think it's necessary for alignment but not something to fix right now since the main concern is the underlying foundation.

oliviawongnyc commented 1 month ago

pixel perfect compared to what?

To what we have now. There are some changes but I think this difference is crucial -- the alignment of the content:

Screenshot 2024-10-28 at 12 08 38 PM

In prod, the "Content Top" and "Content Primary" align with the Hero. I think it's necessary for alignment but not something to fix right now since the main concern is the underlying foundation.

@EdwinGuzman ahhh, got it. But this may actually concern the underlying foundation. This problem occurs because Hero is now outside of the grid so I'll have to think about that.