Open oliviawongnyc opened 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nypl-design-system | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 24, 2024 3:25pm |
Your pull request is missing a changelog—was that intentional?
Just some notes. It's not a perfect pixel-to-pixel update but as a POC it's coming along nicely.
@EdwinGuzman, pixel perfect compared to what? Marty's PR or what we have now? It shouldn't be pixel perfect compared to what we have now given it includes a responsive sidebar, padding, and gaps.
pixel perfect compared to what?
To what we have now. There are some changes but I think this difference is crucial -- the alignment of the content:
In prod, the "Content Top" and "Content Primary" align with the Hero. I think it's necessary for alignment but not something to fix right now since the main concern is the underlying foundation.
pixel perfect compared to what?
To what we have now. There are some changes but I think this difference is crucial -- the alignment of the content:
In prod, the "Content Top" and "Content Primary" align with the Hero. I think it's necessary for alignment but not something to fix right now since the main concern is the underlying foundation.
@EdwinGuzman ahhh, got it. But this may actually concern the underlying foundation. This problem occurs because Hero is now outside of the grid so I'll have to think about that.
Fixes JIRA ticket DSD-1851
This PR does the following:
outlineOffset
property to make the focus ring visible even withoverflow: hidden
turned onTemplate
TAD and is not expected to be mergedHow has this been tested?
Accessibility concerns or updates
Accessibility Checklist
aria-live
is used, a screenreader was used to verify the text is read.ref
s, focus management was reviewed.Open Questions
-
Checklist:
Front End Review: