search

NYPL / nypl-recap-admin

An admin interface for ReCap/SCSB written in Node/Express/React
0 stars 0 forks source link

Make refile error requests #15

Closed ktp242 closed 6 years ago

ktp242 commented 6 years ago

This PR is based on part of Rafael's work of data flow. But mainly, focuses on the basic skeleton of Refile page and making requests to get refile errors.

Now the endpoint's queries are hard coded because the PR is getting quite big now. In the next PR, the queries will be dynamic.

It also moved the secret to .env file and adds the .env.example file. So we don't have to put env variables at the command line anymore. In the next PR, it will also move SQS endpoint to the .env file.

ktp242 commented 6 years ago

We don't use any redux related functions so far as I have observed. The reason why I kept them is thinking we will visit redux in the future. How do you think? They don't do anything now yet and don't break the APP either.

thisisstephenbetts commented 6 years ago

Y'know, I think we should remove them. It's confusing for any future engineers looking at it, and it's quite possible things may have moved on by the time we do get to address it. If it's quick'n'easy to just remove those bits then I think we should do it.

Fewer lines of code, fewer things to go wrong!

Thank you!

ktp242 commented 6 years ago

OK I will remove them! You are right we might want to use different approaches in the future.

ktp242 commented 6 years ago

I have removed redux from here!