NYPL / staff-picks

1 stars 3 forks source link

Book detail page #167

Closed EdwinGuzman closed 6 years ago

EdwinGuzman commented 6 years ago

Fixes #166 and WWW-100.

Updates the book details page and fixes the issue with getting all the filters from the data model.

Example links:

EdwinGuzman commented 6 years ago

Gah, I didn't commit them. Will update.

EdwinGuzman commented 6 years ago

Updated and added tests.

EdwinGuzman commented 6 years ago

@gkallenberg yes, removed. Thanks 👀 .

gkallenberg commented 6 years ago

One other thing I found which may or may not be a design problem, but at what appears to be the 483px breakpoint, the image min-height is set to 470px which stretches the display when wrapping the "picked by" text. Can that min-height be changed to be more responsive or is that a best practice. I don't mind whitespace, but it seems a bit odd for that particular display break.

ricardoom commented 6 years ago

@gkallenberg, Could you hook up a screen shot?

gkallenberg commented 6 years ago

@ricardogalvez screen gap

ricardoom commented 6 years ago

cool one.

holingpoon commented 6 years ago

Travis is in green anyway, I would just like to know if I should be concerned about the warnings returned by the test suite: BookPage Component

EdwinGuzman commented 6 years ago

Updated the Action warning, the other is not as bad so leaving it there.